Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Add tokens/NFTs button triggers multiple times #3824

Merged
merged 6 commits into from
Mar 2, 2022
Merged

[FIX] Add tokens/NFTs button triggers multiple times #3824

merged 6 commits into from
Mar 2, 2022

Conversation

gantunesr
Copy link
Member

Description

Whenever a user double taps on the either the import NFT button or import token button the view appears twice.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #3757

@gantunesr gantunesr added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Feb 28, 2022
@gantunesr gantunesr requested a review from a team as a code owner February 28, 2022 13:27
@blackdevelopa
Copy link
Contributor

LGTM

@gantunesr gantunesr removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 1, 2022
Fatxx
Fatxx reviewed Mar 1, 2022
View reviewed changes
Copy link
Contributor

@Fatxx Fatxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr added Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Mar 1, 2022
@gantunesr gantunesr added the Priority - Low Task with low priority label Mar 2, 2022
@gantunesr gantunesr merged commit adfef1e into main Mar 2, 2022
@gantunesr gantunesr deleted the fix/buttons-multiple-trigger branch March 2, 2022 01:10
@github-actions github-actions bot locked and limited conversation to collaborators Mar 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Fatxx Fatxx Fatxx approved these changes

Assignees
No one assigned
Labels
Priority - Low Task with low priority Spot Check on the Release Build If a ticket doesn't require feature QA, but does require some form of manual spot checking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Double tapping on the import tokens, import NFT's
3 participants
@gantunesr @blackdevelopa @Fatxx